Skip to content

feat: Add support for Hubble control plane in Retina agent #1614

feat: Add support for Hubble control plane in Retina agent

feat: Add support for Hubble control plane in Retina agent #1614

Triggered via pull request June 14, 2024 16:49
Status Failure
Total duration 5m 25s
Artifacts

golangci-lint.yaml

on: pull_request
Matrix: Lint
Fit to window
Zoom out
Zoom in

Annotations

26 errors
Lint (windows, arm64): pkg/hubble/hubble.go#L18
could not import github.com/cilium/cilium/pkg/hubble/server/serveroption (-: # github.com/cilium/cilium/pkg/hubble/server/serveroption
Lint (windows, arm64)
undefined: unix.Unlink) (typecheck)
Lint (windows, arm64): pkg/monitoragent/cell.go#L14
could not import github.com/cilium/cilium/pkg/monitor/agent/listener (-: # github.com/cilium/cilium/pkg/monitor/agent/listener
Lint (windows, arm64)
undefined: unix.Errno
Lint (windows, arm64)
undefined: unix.EPIPE) (typecheck)
Lint (windows, arm64): cmd/legacy/daemon.go#L190
exitAfterDefer: os.Exit will exit, and `defer zl.Close()` will not run (gocritic)
Lint (windows, arm64): cmd/legacy/daemon.go#L221
shadow: declaration of "err" shadows declaration at line 95 (govet)
Lint (windows, arm64)
issues found
Lint (windows, amd64): pkg/hubble/hubble.go#L18
could not import github.com/cilium/cilium/pkg/hubble/server/serveroption (-: # github.com/cilium/cilium/pkg/hubble/server/serveroption
Lint (windows, amd64)
undefined: unix.Unlink) (typecheck)
Lint (windows, amd64): pkg/monitoragent/cell.go#L14
could not import github.com/cilium/cilium/pkg/monitor/agent/listener (-: # github.com/cilium/cilium/pkg/monitor/agent/listener
Lint (windows, amd64)
undefined: unix.Errno
Lint (windows, amd64)
undefined: unix.EPIPE) (typecheck)
Lint (windows, amd64): cmd/legacy/daemon.go#L190
exitAfterDefer: os.Exit will exit, and `defer zl.Close()` will not run (gocritic)
Lint (windows, amd64): cmd/legacy/daemon.go#L221
shadow: declaration of "err" shadows declaration at line 95 (govet)
Lint (windows, amd64)
issues found
Lint (linux, arm64): cmd/hubble/daemon_main.go#L313
commentedOutCode: may want to remove commented-out code (gocritic)
Lint (linux, arm64): cmd/hubble/subcmd.go#L16
commentedOutCode: may want to remove commented-out code (gocritic)
Lint (linux, arm64): cmd/legacy/daemon.go#L190
exitAfterDefer: os.Exit will exit, and `defer zl.Close()` will not run (gocritic)
Lint (linux, arm64): cmd/hubble/daemon.go#L108
newDaemon - result 1 (error) is always nil (unparam)
Lint (linux, arm64): cmd/hubble/daemon_main.go#L301
mnd: Magic number: 2, in <argument> detected (gomnd)
Lint (linux, arm64): cmd/hubble/daemon_main.go#L257
mnd: Magic number: 100, in <assign> detected (gomnd)
Lint (linux, arm64): cmd/hubble/daemon_main.go#L258
mnd: Magic number: 3, in <assign> detected (gomnd)
Lint (linux, arm64): cmd/hubble/daemon_main.go#L259
mnd: Magic number: 30, in <assign> detected (gomnd)
Lint (linux, arm64): cmd/legacy/daemon.go#L221
shadow: declaration of "err" shadows declaration at line 95 (govet)
Lint (linux, arm64): cmd/hubble/daemon_main.go#L51
SA9004: only the first constant in this group has an explicit type (staticcheck)