Allow target function to output columns already present in the data set #3214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
promptflow-evals test result 9 files 9 suites 2h 11m 6s ⏱️ Results for commit 9badde3. ♻️ This comment has been updated with latest results. |
…irovins/allow_output_as_input
nagkumar91
approved these changes
May 13, 2024
luigiw
approved these changes
May 13, 2024
ninghu
reviewed
May 14, 2024
Comment on lines
+318
to
+329
| for evaluator_name, mapping in evaluator_config.items(): | ||
| mapped_to_values = set(mapping.values()) | ||
| for col in target_generated_columns: | ||
| # If user defined mapping differently, do not change it. | ||
| # If it was mapped to target, we have already changed it | ||
| # in _process_evaluator_config | ||
| run_output = f'${{run.outputs.{col}}}' | ||
| # We will add our mapping only if | ||
| # customer did not mapped target output. | ||
| if col not in mapping and run_output not in mapped_to_values: | ||
| evaluator_config[evaluator_name][col] = run_output | ||
|
|
There was a problem hiding this comment.
Not sure why we would need the code here.
There was a problem hiding this comment.
In this case we are making sure, we map all the outputs of target function to the apropriate columns in the evaluators input, however, we should not do that if customer have mapped this output to something else.
7 tasks
nick863
added a commit
that referenced
this pull request
May 14, 2024
# Description This PR contains follow up changes for PR #3214 # All Promptflow Contribution checklist: - [x] **The pull request does not introduce [breaking changes].** - [x] **CHANGELOG is updated for new features, bug fixes or other significant changes.** - [x] **I have read the [contribution guidelines](../CONTRIBUTING.md).** - [x] **Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: [suggested workflow](../CONTRIBUTING.md#suggested-workflow).** ## General Guidelines and Best Practices - [x] Title of the pull request is clear and informative. - [x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, [see this page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md). ### Testing Guidelines - [x] Pull request includes test coverage for the included changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently target function will fail if its output column will be present in the input data set. In this PR we are fixing it. See work item #3170343.
All Promptflow Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines