Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal][Executor] Return inputs definition and has aggregation by initialize api in execution server #3212

Merged
merged 7 commits into from
May 11, 2024

Conversation

PeiwenGaoMS
Copy link
Contributor

@PeiwenGaoMS PeiwenGaoMS commented May 11, 2024

Description

Return inputs definition and has aggregation by initialize api in execution server to avoid creating flow executor in runtime container.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@PeiwenGaoMS PeiwenGaoMS requested a review from a team as a code owner May 11, 2024 04:23
Copy link

github-actions bot commented May 11, 2024

promptflow SDK CLI Azure E2E Test Result devs/peiwen/return_info_by_init

  4 files    4 suites   4m 9s ⏱️
242 tests 205 ✅  37 💤 0 ❌
968 runs  820 ✅ 148 💤 0 ❌

Results for commit 1449eeb.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 11, 2024

promptflow-core test result

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 1449eeb.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 11, 2024

SDK CLI Global Config Test Result devs/peiwen/return_info_by_init

6 tests   6 ✅  1m 14s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 1449eeb.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 11, 2024

Executor Unit Test Result devs/peiwen/return_info_by_init

796 tests   796 ✅  3m 48s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 1449eeb.

♻️ This comment has been updated with latest results.

@PeiwenGaoMS PeiwenGaoMS merged commit 2cf0fbe into main May 11, 2024
51 checks passed
@PeiwenGaoMS PeiwenGaoMS deleted the devs/peiwen/return_info_by_init branch May 11, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants