Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[azure][trace] Check trace Cosmos status and log warnings if not ready #3200

Merged
merged 29 commits into from May 13, 2024

Conversation

zhengfeiwang
Copy link
Contributor

@zhengfeiwang zhengfeiwang commented May 10, 2024

Description

This PR mainly targets to add a check for trace Cosmos DB status during create Azure run. If the Cosmos is not ready, will log a warning on that to hint user enable with pf config set.

Warning message

Local to cloud

image

Submit run to Azure

image

As this change will add one new request during pfazure run create, so this PR also contains the changes that update the recordings.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link

github-actions bot commented May 10, 2024

promptflow SDK CLI Azure E2E Test Result zhengfei/feature/honor-service-cosmos-status

  4 files    4 suites   4m 13s ⏱️
242 tests 204 ✅  38 💤 0 ❌
968 runs  816 ✅ 152 💤 0 ❌

Results for commit aab5104.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 10, 2024

SDK CLI Global Config Test Result zhengfei/feature/honor-service-cosmos-status

6 tests   6 ✅  1m 24s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit aab5104.

♻️ This comment has been updated with latest results.

@wangchao1230 wangchao1230 marked this pull request as ready for review May 13, 2024 04:13
@wangchao1230 wangchao1230 requested a review from a team as a code owner May 13, 2024 04:13
@wangchao1230 wangchao1230 merged commit b01ce40 into main May 13, 2024
41 checks passed
@wangchao1230 wangchao1230 deleted the zhengfei/feature/honor-service-cosmos-status branch May 13, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants