New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[azure][trace] Check trace Cosmos status and log warnings if not ready #3200
Merged
wangchao1230
merged 29 commits into
main
from
zhengfei/feature/honor-service-cosmos-status
May 13, 2024
Merged
[azure][trace] Check trace Cosmos status and log warnings if not ready #3200
wangchao1230
merged 29 commits into
main
from
zhengfei/feature/honor-service-cosmos-status
May 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
promptflow SDK CLI Azure E2E Test Result zhengfei/feature/honor-service-cosmos-status 4 files 4 suites 4m 13s ⏱️ Results for commit aab5104. ♻️ This comment has been updated with latest results. |
SDK CLI Global Config Test Result zhengfei/feature/honor-service-cosmos-status6 tests 6 ✅ 1m 24s ⏱️ Results for commit aab5104. ♻️ This comment has been updated with latest results. |
crazygao
approved these changes
May 13, 2024
wangchao1230
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR mainly targets to add a check for trace Cosmos DB status during create Azure run. If the Cosmos is not ready, will log a warning on that to hint user enable with
pf config set
.Warning message
Local to cloud
Submit run to Azure
As this change will add one new request during
pfazure run create
, so this PR also contains the changes that update the recordings.All Promptflow Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines