Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Gen meta before update signatures #3195

Merged
merged 4 commits into from May 11, 2024
Merged

Conversation

D-W-
Copy link
Contributor

@D-W- D-W- commented May 10, 2024

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

This pull request includes changes that primarily focus on modifying the handling of flow variants and initial keyword arguments (init_kwargs) in the promptflow-devkit package. The most significant changes involve removing the usage of ProxyFactory and its prepare_metadata method, adding init_kwargs parameter to various methods and functions, and modifying the flow_overwrite_context function to accommodate these changes.

Here are the key changes, grouped by their themes:

Removal of ProxyFactory:

Changes to init_kwargs handling:

These changes seem to simplify the codebase by reducing the reliance on the ProxyFactory and its prepare_metadata method, and provide a more consistent way of handling init_kwargs across different methods and functions.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link

github-actions bot commented May 10, 2024

promptflow SDK CLI Azure E2E Test Result wanhan/fix_c_sharp_meta_generation

  4 files    4 suites   4m 9s ⏱️
242 tests 206 ✅  36 💤 0 ❌
968 runs  824 ✅ 144 💤 0 ❌

Results for commit ed8828b.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 10, 2024

SDK CLI Global Config Test Result wanhan/fix_c_sharp_meta_generation

6 tests   6 ✅  1m 13s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit ed8828b.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 10, 2024

Executor Unit Test Result wanhan/fix_c_sharp_meta_generation

792 tests   792 ✅  3m 44s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit ed8828b.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 10, 2024

Executor E2E Test Result wanhan/fix_c_sharp_meta_generation

243 tests   238 ✅  5m 35s ⏱️
  1 suites    5 💤
  1 files      0 ❌

Results for commit ed8828b.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 10, 2024

SDK CLI Test Result wanhan/fix_c_sharp_meta_generation

    4 files      4 suites   1h 2m 25s ⏱️
  708 tests   667 ✅  41 💤 0 ❌
2 832 runs  2 668 ✅ 164 💤 0 ❌

Results for commit ed8828b.

♻️ This comment has been updated with latest results.

@D-W- D-W- changed the title [DSK] Gen meta before update signatures [SDK] Gen meta before update signatures May 11, 2024
@D-W- D-W- merged commit 2233993 into main May 11, 2024
41 checks passed
@D-W- D-W- deleted the wanhan/fix_c_sharp_meta_generation branch May 11, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants