Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support serving engine switch in pf serve cmd #3161

Merged
merged 10 commits into from May 11, 2024

Conversation

wxpjimmy
Copy link
Contributor

@wxpjimmy wxpjimmy commented May 9, 2024

Description

Add --engine parameter in pf flow serve command, customer can use this parameter to switch the python serving engine between flask and fastapi, it's default to flask

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link

github-actions bot commented May 9, 2024

promptflow SDK CLI Azure E2E Test Result xiaopwan/support_serving_engine_switch_in_pf_serve_cmd

  4 files    4 suites   4m 9s ⏱️
242 tests 205 ✅  37 💤 0 ❌
968 runs  820 ✅ 148 💤 0 ❌

Results for commit f5e97f4.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 9, 2024

SDK CLI Global Config Test Result xiaopwan/support_serving_engine_switch_in_pf_serve_cmd

6 tests   6 ✅  1m 10s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit f5e97f4.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 9, 2024

Executor Unit Test Result xiaopwan/support_serving_engine_switch_in_pf_serve_cmd

792 tests   792 ✅  3m 45s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit f5e97f4.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 9, 2024

Executor E2E Test Result xiaopwan/support_serving_engine_switch_in_pf_serve_cmd

243 tests   238 ✅  5m 32s ⏱️
  1 suites    5 💤
  1 files      0 ❌

Results for commit f5e97f4.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 9, 2024

SDK CLI Test Result xiaopwan/support_serving_engine_switch_in_pf_serve_cmd

    4 files      4 suites   1h 3m 9s ⏱️
  714 tests   673 ✅  41 💤 0 ❌
2 856 runs  2 692 ✅ 164 💤 0 ❌

Results for commit f5e97f4.

♻️ This comment has been updated with latest results.

thy09
thy09 previously approved these changes May 9, 2024
wangchao1230
wangchao1230 previously approved these changes May 11, 2024
brynn-code
brynn-code previously approved these changes May 11, 2024
@wxpjimmy wxpjimmy merged commit dbd9b42 into main May 11, 2024
41 checks passed
@wxpjimmy wxpjimmy deleted the xiaopwan/support_serving_engine_switch_in_pf_serve_cmd branch May 11, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation promptflow promptflow-devkit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants