Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix][Executor] Fix the issue of duplicate line numbers in the chat group run scenario #3145

Merged
merged 33 commits into from May 13, 2024

Conversation

PeiwenGaoMS
Copy link
Contributor

@PeiwenGaoMS PeiwenGaoMS commented May 8, 2024

Description

In a chat group run, the line_number remains consistent within each round, which can lead to the current flow run within a round possibly getting the result of the previous one. To ensure the uniqueness of each request and retrieve the correct execution results, we use request_id (uuid) as the key for the result dictionary.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link

github-actions bot commented May 8, 2024

promptflow SDK CLI Azure E2E Test Result devs/peiwen/fix_chatgroup_run

  4 files    4 suites   4m 10s ⏱️
242 tests 205 ✅  37 💤 0 ❌
968 runs  820 ✅ 148 💤 0 ❌

Results for commit 9b639b8.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 8, 2024

SDK CLI Global Config Test Result devs/peiwen/fix_chatgroup_run

6 tests   6 ✅  1m 14s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 9b639b8.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 8, 2024

promptflow-core test result

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 9b639b8.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 8, 2024

Executor Unit Test Result devs/peiwen/fix_chatgroup_run

796 tests   796 ✅  3m 46s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 9b639b8.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 8, 2024

Executor E2E Test Result devs/peiwen/fix_chatgroup_run

243 tests   238 ✅  5m 24s ⏱️
  1 suites    5 💤
  1 files      0 ❌

Results for commit 9b639b8.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 8, 2024

SDK CLI Test Result devs/peiwen/fix_chatgroup_run

    4 files      4 suites   1h 3m 35s ⏱️
  715 tests   674 ✅  41 💤 0 ❌
2 860 runs  2 696 ✅ 164 💤 0 ❌

Results for commit 9b639b8.

♻️ This comment has been updated with latest results.

@PeiwenGaoMS PeiwenGaoMS merged commit 5bd42ad into main May 13, 2024
51 checks passed
@PeiwenGaoMS PeiwenGaoMS deleted the devs/peiwen/fix_chatgroup_run branch May 13, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants