Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Executor] Convert sync generator to async generator #3144

Merged
merged 2 commits into from May 13, 2024
Merged

Conversation

thy09
Copy link
Contributor

@thy09 thy09 commented May 8, 2024

Description

Quick fix for the issue #3069

This pull request primarily focuses on changes to the promptflow-core package to improve handling of synchronous and asynchronous iterators. The most significant changes include the creation of a new function sync_iterator_to_async in async_utils.py and its subsequent integration into the flow_executor.py module.

Here are the key changes, grouped by theme:

Addition of new utility function:

Changes to the flow_executor.py module:

These changes enhance the flexibility of the promptflow-core package by allowing it to handle both synchronous and asynchronous iterators effectively.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link

github-actions bot commented May 8, 2024

promptflow SDK CLI Azure E2E Test Result heta/sync-to-async

  4 files    4 suites   4m 10s ⏱️
242 tests 205 ✅  37 💤 0 ❌
968 runs  820 ✅ 148 💤 0 ❌

Results for commit b80d729.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 8, 2024

promptflow-core test result

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit b80d729.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 8, 2024

SDK CLI Global Config Test Result heta/sync-to-async

6 tests   6 ✅  1m 17s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit b80d729.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 8, 2024

Executor Unit Test Result heta/sync-to-async

796 tests   796 ✅  3m 44s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit b80d729.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 8, 2024

Executor E2E Test Result heta/sync-to-async

243 tests   238 ✅  5m 38s ⏱️
  1 suites    5 💤
  1 files      0 ❌

Results for commit b80d729.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 8, 2024

SDK CLI Test Result heta/sync-to-async

    4 files      4 suites   1h 3m 35s ⏱️
  715 tests   674 ✅  41 💤 0 ❌
2 860 runs  2 696 ✅ 164 💤 0 ❌

Results for commit b80d729.

♻️ This comment has been updated with latest results.

@thy09 thy09 merged commit c11438f into main May 13, 2024
51 checks passed
@thy09 thy09 deleted the heta/sync-to-async branch May 13, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants