Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up stderr out on tests, use Node.findall in docstring parser #3103

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

glharper
Copy link
Member

@glharper glharper commented May 2, 2024

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

Remove some deprecation warnings from test output, use Node.findall instead of deprecated traverse API in docstring_parser

All Promptflow Contribution checklist:

  • [x ] The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • [ x] I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • [ x] Title of the pull request is clear and informative.
  • [x ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link

Hi, thank you for your interest in helping to improve the prompt flow experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment.

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue/pull request label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Improvements on examples external fundamental no-recent-activity There has been no recent activity on this issue/pull request promptflow promptflow-core promptflow-tools promptflow tools code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant