New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate groups when collect tool packages #3085
base: main
Are you sure you want to change the base?
Conversation
promptflow SDK CLI Azure E2E Test Result chesi/validate-group 4 files 4 suites 4m 7s ⏱️ Results for commit 5cd6534. |
promptflow-core test result0 tests 0 ✅ 0s ⏱️ Results for commit 5cd6534. |
SDK CLI Global Config Test Result chesi/validate-group6 tests 6 ✅ 1m 19s ⏱️ Results for commit 5cd6534. |
Executor E2E Test Result chesi/validate-group242 tests 237 ✅ 5m 9s ⏱️ Results for commit 5cd6534. |
Executor Unit Test Result chesi/validate-group797 tests 797 ✅ 3m 44s ⏱️ Results for commit 5cd6534. |
SDK CLI Test Result chesi/validate-group 4 files 4 suites 59m 4s ⏱️ Results for commit 5cd6534. |
"""Validate groups if exist in tool spec.""" | ||
tool_name = tool.get("name", "") | ||
groups = tool.get("groups", "") | ||
invalid_group_names = ["advanced"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
invalid -> reserved
message_format=message_format, | ||
ErrorTarget=ErrorTarget.TOOL) | ||
|
||
# Some group names cannot be used like advanced |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please explain why.
message_format=message_format, | ||
ErrorTarget=ErrorTarget.TOOL) | ||
|
||
# Group name should be unique |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think duplicate group name may hit yaml load error? Why do we not need such logic for tool input name duplication?
Hi, thank you for your interest in helping to improve the prompt flow experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. |
Description
Validate groups when collect tool packages.
Portal:
Test image: promptflow.azurecr.io/promptflow-runtime:pr-1344775-v13
Extension:
pf-tool version: 0.0.410 --extra-index-url https://azuremlsdktestpypi.azureedge.net/test-promptflow/
pf version: 1.10.0.dev125798419 --extra-index-url https://azuremlsdktestpypi.azureedge.net/promptflow
Only list valid tools:
Warning in logs: pf tool list
All Promptflow Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines