Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devops: move microphone access into own action #30634

Merged
merged 1 commit into from May 8, 2024

Conversation

mxschmitt
Copy link
Member

Motivation: This is not only a problem on macOS 14, it seems to also affect macOS 12/13. Also this enables us to re-use this across the language port repositories or internal tests.

@mxschmitt mxschmitt marked this pull request as draft May 2, 2024 14:18
@mxschmitt mxschmitt added the CQ1 label May 2, 2024
Copy link
Contributor

github-actions bot commented May 2, 2024

Test results for "tests 1"

2 flaky ⚠️ [playwright-test] › ui-mode-test-progress.spec.ts:22:5 › should update trace live
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all

27277 passed, 671 skipped
✔️✔️✔️

Merge workflow run.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented May 2, 2024

Test results for "tests 2"

4 fatal errors, not part of any test
9 failed
❌ [chromium-library] › library/browsercontext-proxy.spec.ts:52:3 › should work when passing the proxy only on the context level
❌ [chromium-page] › page/page-screenshot.spec.ts:272:5 › page screenshot › should work for canvas
❌ [firefox-library] › library/inspector/cli-codegen-2.spec.ts:340:7 › cli codegen › should record open in a new tab with url
❌ [firefox-library] › library/inspector/cli-codegen-2.spec.ts:340:7 › cli codegen › should record open in a new tab with url
❌ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:493:7 › cli codegen › should --save-trace
❌ [webkit-library] › library/signals.spec.ts:62:7 › signals › should report browser close signal 2
❌ [webkit-library] › library/capabilities.spec.ts:67:3 › should play video @smoke
❌ [webkit-library] › library/capabilities.spec.ts:99:3 › should play audio @smoke
❌ [webkit-library] › library/signals.spec.ts:62:7 › signals › should report browser close signal 2

61 flaky ⚠️ [chromium-library] › library/trace-viewer.spec.ts:893:1 › should display waitForLoadState even if did not wait for it
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1119:3 › should work with connectOverCDP
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:381:5 › run-server › should emit close events on pages and contexts
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:642:5 › run-server › should fulfill with global fetch result
⚠️ [chromium-library] › library/downloads-path.spec.ts:32:5 › downloads path › should keep downloadsPath folder
⚠️ [chromium-library] › library/downloads-path.spec.ts:48:5 › downloads path › should delete downloads when context closes
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har
⚠️ [chromium-page] › page/page-drag.spec.ts:25:5 › Drag and drop › should work @smoke
⚠️ [chromium-library] › library/browsercontext-viewport.spec.ts:143:12 › should drag with high dpi
⚠️ [chromium-page] › page/page-add-locator-handler.spec.ts:90:5 › should work with locator.hover()
⚠️ [chromium-page] › page/page-drag.spec.ts:53:5 › Drag and drop › should not send dragover on the first mousemove
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:705:7 › cli codegen › should ignore AltGraph
⚠️ [chromium-page] › page/page-event-request.spec.ts:110:3 › should report navigation requests and responses handled by service worker
⚠️ [chromium-library] › library/trace-viewer.spec.ts:893:1 › should display waitForLoadState even if did not wait for it
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:23:7 › cli codegen › should click
⚠️ [chromium-library] › library/popup.spec.ts:264:3 › should not throw when click closes popup
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:23:7 › cli codegen › should click
⚠️ [firefox-page] › page/page-click.spec.ts:850:3 › should not hang when frame is detached
⚠️ [firefox-page] › page/frame-goto.spec.ts:46:3 › should continue after client redirect
⚠️ [firefox-library] › library/browsercontext-basic.spec.ts:331:3 › should emulate media in cross-process iframe
⚠️ [firefox-library] › library/video.spec.ts:189:5 › screencast › should capture static page
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:159:7 › cli codegen › should work with TrustedTypes
⚠️ [firefox-library] › library/tap.spec.ts:23:3 › should send all of the correct events @smoke
⚠️ [firefox-library] › library/video.spec.ts:189:5 › screencast › should capture static page
⚠️ [firefox-page] › page/page-drag.spec.ts:272:5 › Drag and drop › should work if a frame is stalled
⚠️ [firefox-page] › page/page-mouse.spec.ts:166:3 › should trigger hover state
⚠️ [firefox-page] › page/elementhandle-scroll-into-view.spec.ts:103:3 › should wait for element to stop moving
⚠️ [firefox-page] › page/page-click.spec.ts:99:3 › should click the 1x1 div
⚠️ [firefox-page] › page/page-dialog.spec.ts:20:3 › should fire
⚠️ [firefox-page] › page/page-click.spec.ts:850:3 › should not hang when frame is detached
⚠️ [firefox-page] › page/page-event-request.spec.ts:171:3 › should return response body when Cross-Origin-Opener-Policy is set
⚠️ [firefox-page] › page/page-goto.spec.ts:81:3 › should work with Cross-Origin-Opener-Policy
⚠️ [firefox-library] › library/tracing.spec.ts:412:14 › should produce screencast frames scale
⚠️ [firefox-page] › page/page-goto.spec.ts:81:3 › should work with Cross-Origin-Opener-Policy
⚠️ [chromium-library] › library/capabilities.spec.ts:140:3 › should not crash on showDirectoryPicker
⚠️ [chromium-page] › page/page-add-locator-handler.spec.ts:90:5 › should work with locator.hover()
⚠️ [chromium-page] › page/page-drag.spec.ts:70:5 › Drag and drop › should work inside iframe
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:23:7 › cli codegen › should click
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:24:7 › cli codegen › should contain open page
⚠️ [chromium-page] › page/page-set-input-files.spec.ts:157:3 › should upload large file with relative path
⚠️ [firefox-page] › page/frame-goto.spec.ts:46:3 › should continue after client redirect
⚠️ [webkit-library] › library/inspector/cli-codegen-test.spec.ts:88:5 › should work with --save-har
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:56:7 › cli codegen › should ignore programmatic events
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:228:7 › cli codegen › should fill
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:341:7 › cli codegen › should press
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:451:7 › cli codegen › should check
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:521:7 › cli codegen › should uncheck
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:553:7 › cli codegen › should select
⚠️ [webkit-page] › page/page-drag.spec.ts:330:5 › Drag and drop › should work with locators
⚠️ [webkit-page] › page/page-mouse.spec.ts:147:3 › should select the text with mouse
⚠️ [webkit-library] › library/browsercontext-viewport.spec.ts:143:12 › should drag with high dpi
⚠️ [webkit-library] › library/emulation-focus.spec.ts:202:12 › should trigger hover state concurrently
⚠️ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:340:7 › cli codegen › should record open in a new tab with url
⚠️ [webkit-page] › page/page-drag.spec.ts:34:5 › Drag and drop › should send the right events
⚠️ [webkit-page] › page/page-drag.spec.ts:289:5 › Drag and drop › should work with the helper method
⚠️ [webkit-page] › page/page-request-fallback.spec.ts:239:5 › post data › should amend binary post data
⚠️ [webkit-library] › library/trace-viewer.spec.ts:893:1 › should display waitForLoadState even if did not wait for it
⚠️ [webkit-library] › library/tracing.spec.ts:412:14 › should produce screencast frames fit
⚠️ [webkit-library] › library/tracing.spec.ts:412:14 › should produce screencast frames scale

182337 passed, 7985 skipped, 2636 did not run
✔️✔️✔️

Merge workflow run.

@mxschmitt mxschmitt marked this pull request as ready for review May 8, 2024 19:03
@mxschmitt mxschmitt merged commit 8ef32a9 into microsoft:main May 8, 2024
89 of 99 checks passed
thebigbrain pushed a commit to thebigbrain/playwright that referenced this pull request May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants