feat(ct): resolve hooksConfig import refs #30455
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
sand4rt
force-pushed
the
ct-resolve-hooks-config
branch
from
9a15f00
to
3018962
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
sand4rt
force-pushed
the
ct-resolve-hooks-config
branch
from
fafa376
to
cee7600
Compare
This comment has been minimized.
This comment has been minimized.
sand4rt
commented
Apr 26, 2024
sand4rt
commented
Apr 26, 2024
sand4rt
force-pushed
the
ct-resolve-hooks-config
branch
from
cee7600
to
81bca97
Compare
This comment has been minimized.
This comment has been minimized.
sand4rt
changed the title
Test results for "tests 1"1 flaky27248 passed, 671 skipped Merge workflow run. |
|
👋 @sand4rt 👋 taking care of our review debt. is this something you'd like me to look at? |
|
👋 @pavelfeldman, yes please. Let me know if more info is needed |
|
Tried reviewing it and failed - sounds like too many things are happening at a time. Any chance for it to be split in chunks? Also spotted a declare module there, we have general distaste to those, we like types to chain / infer explicitly instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #30453 and #19933