[DatePicker, Calendar] Fix not updating correctly when used with EditContext #2047
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
When using a FluentDatePicker or FluentCalender inside an EditContext, there are issues with selecting a new value in the Year-view of the calendar. My diagnosis suggests that this comes down to a race condition-like issue between invoking ValueChanged and also notifying the EditContext about changes which will propagate the "old" value to the component through the parameters being updated.
The changes I propose changes the approach for updating value of the FluentCalendar (and thus FluentDatePicker) by utilizing
SetCurrentValueAsync
available onFluentInputBase
. This approach is similar to other components whereSetCurrentValueAsync
is called as part ofChangeHandlerAsync
.The changes proposed fixes the issue.
🎫 Issues
#2046
👩💻 Reviewer Notes
📑 Test Plan
I tested all the DatePicker/Calendar examples in the sample project.
✅ Checklist
General
Component-specific
⏭ Next Steps