[FluentIcon] Minor cleanup and clarification #2038
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
π Description
FluentIcon
. Removes invalidwidth
attribute fromSVG
style whenWidth
set tostring.Empty
Width
set tostring.Empty
.π« Issues
For responsive layout, it is preferable to use CSS versus embedding the style in HTML. The
width
of the SVG is embedded unlessFluentIcon
'sWidth
is explicity set tostring.Empty
π©βπ» Reviewer Notes
Any suggestions to the update on the documentation page? I wanted to add some information about this behavior without getting into a specific use case.
π Test Plan
β Checklist
General
Component-specific
β Next Steps