Added release logic to Optimization Engine #703
Conversation
Co-authored-by: Michael Flanakin <[email protected]>
Co-authored-by: Michael Flanakin <[email protected]>
Co-authored-by: Michael Flanakin <[email protected]>
Co-authored-by: Michael Flanakin <[email protected]>
microsoft-github-policy-service
bot
added
the
Needs: Review 👀
| @@ -118,3 +118,28 @@ Get-ChildItem "$PSScriptRoot/../templates/$Template*" -Directory -ErrorAction Si | |||
|
|
|||
| Write-Host '' | |||
| } | |||
|
|
|||
| # Package optimization engine | |||
There was a problem hiding this comment.
nit: Should we move this into a separate Build-OptimizationEngine script? 🤔 I'm fine keeping it here. Just thinking out loud. Fwiw, the templates should probably be moved to a Build-Template script as well. Alternatively, we can keep it here for now and define a more general approach to solve this consistently. I'm fine with anything. Just wanted to share that to see what your thoughts are.
There was a problem hiding this comment.
Well, if we move templates and AOE to a different script, why don't we move workbooks and Bicep registry modules as well? Maybe each toolkit component type should have its own build script following some naming pattern and then we had the Build-Toolkit script calling all of them, provided the component directory (templates, workbooks, aoe, etc.) had a build script... But I'd keep it as is for now. I am adding a TODO to review the logic. If you prefer, I can open an issue for this.
| Copy-Item "$path/azuredeploy.json" "$deployDir/$($path.Name)-latest.json" | ||
|
|
||
| $packageManifestPath = "$path/package-manifest.json" | ||
| if (Test-Path $packageManifestPath) |
There was a problem hiding this comment.
nit: Would it be better to define a fallback manifest instead of just falling back to the previous logic? That way, we always work with a manifest, we just define a default one. I'm okay to not do that or maybe just add a TODO comment. Just a thought that crossed my mind.
There was a problem hiding this comment.
Yes, I agree. I was about to include this change, but then I thought: where do we define the fallback manifest? Inline or as a file placed somewhere in the src structure? As I didn't want to make this decision now, I am leaving a TODO comment for now.
🛠️ Description
Changed build, package and publish scripts to include the required assets for the Optimization Engine release and deployment process. The
docs/deployfolder includes files that are just copies coming from thesrc/optimization-enginefolder.Also included minor bug fixes in workbooks and runbooks.
📋 Checklist
🔬 How did you test this change?
🙋♀️ Do any of the following that apply?
📑 Did you update
docs/changelog.md?📖 Did you update documentation?