#694 log errors when DevTools cannot be started #760
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waldekmastykarz
requested changes
Jun 5, 2024
Signed-off-by: Piotr Karpala <[email protected]>
| catch (NotSupportedException ex) | ||
| { | ||
| Logger.LogError(ex, "Error starting {name}. Error finding the browser.", Name); | ||
| } |
There was a problem hiding this comment.
We should stop early here
| } | ||
|
|
||
| // find if the process is already running | ||
| var processes = Process.GetProcessesByName(Path.GetFileNameWithoutExtension(processName)); |
There was a problem hiding this comment.
This doesn't work on macOS because the actual process name is stored in Process.MainModule.ModuleName, so we need to update this logic to differentiate across OSes
There was a problem hiding this comment.
ok, I'll dust off my MPro and check.
There was a problem hiding this comment.
All good, I've done a couple of updates already
|
I've updated the PR and merged it manually. I've done some changes as to how we detect browsers to accommodate different versions of Edge across OSes. Check out the final commit at: 2d583e3. Thank you so much for working with us on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #694
I'm not sure if we should add support for unit testing and Dispose to cleanup after DevTools?