-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[config] Enhancement: Move config file out of runtime #1290
Conversation
563faf0
to
7655cc6
Compare
Processing commits from 7f8103a to 7655cc6 (in the last 15 days) Performance for Push() in tcp-ping-pong-server Diff since root commit.
Performance for Pop() in tcp-ping-pong-server Diff since root commit.
Performance for Push() in tcp-ping-pong-client Diff since root commit.
Performance for Pop() in tcp-ping-pong-client Diff since root commit.
|
Processing commits from 7f8103a to 7655cc6 (in the last 15 days) Performance for Push() in tcp-ping-pong-server Diff since root commit.
Performance for Pop() in tcp-ping-pong-server Diff since root commit.
Performance for Push() in tcp-ping-pong-client Diff since root commit.
Performance for Pop() in tcp-ping-pong-client Diff since root commit.
|
Processing commits from 7f8103a to 7655cc6 (in the last 15 days) Performance for Push() in tcp-ping-pong-server Diff since root commit.
Performance for Pop() in tcp-ping-pong-server Diff since root commit.
Performance for Push() in tcp-ping-pong-client Diff since root commit.
Performance for Pop() in tcp-ping-pong-client Diff since root commit.
|
Processing commits from 7f8103a to 7655cc6 (in the last 15 days) Performance for Push() in tcp-ping-pong-server Diff since root commit.
Performance for Pop() in tcp-ping-pong-server Diff since root commit.
Performance for Push() in tcp-ping-pong-client Diff since root commit.
Performance for Pop() in tcp-ping-pong-client Diff since root commit.
|
7655cc6
to
f758671
Compare
Processing commits from 7f8103a to f758671 (in the last 15 days) Performance for Push() in tcp-ping-pong-server Diff since root commit.
Performance for Pop() in tcp-ping-pong-server Diff since root commit.
Performance for Push() in tcp-ping-pong-client Diff since root commit.
Performance for Pop() in tcp-ping-pong-client Diff since root commit.
|
Processing commits from 7f8103a to f758671 (in the last 15 days) Performance for Push() in tcp-ping-pong-server Diff since root commit.
Performance for Pop() in tcp-ping-pong-server Diff since root commit.
Performance for Push() in tcp-ping-pong-client Diff since root commit.
Performance for Pop() in tcp-ping-pong-client Diff since root commit.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Processing commits from 7f8103a to b4dd4f6 (in the last 15 days) Performance for Push() in tcp-ping-pong-server Diff since root commit.
Performance for Pop() in tcp-ping-pong-server Diff since root commit.
Performance for Push() in tcp-ping-pong-client Diff since root commit.
Performance for Pop() in tcp-ping-pong-client Diff since root commit.
|
Processing commits from 7f8103a to b4dd4f6 (in the last 15 days) Performance for Push() in tcp-ping-pong-server Diff since root commit.
Performance for Pop() in tcp-ping-pong-server Diff since root commit.
Performance for Push() in tcp-ping-pong-client Diff since root commit.
Performance for Pop() in tcp-ping-pong-client Diff since root commit.
|
Processing commits from 7f8103a to b4dd4f6 (in the last 15 days) Performance for Push() in tcp-ping-pong-server Diff since root commit.
Performance for Pop() in tcp-ping-pong-server Diff since root commit.
Performance for Push() in tcp-ping-pong-client Diff since root commit.
Performance for Pop() in tcp-ping-pong-client Diff since root commit.
|
b4dd4f6
to
2eb73f2
Compare
Processing commits from 7f8103a to 2eb73f2 (in the last 15 days) Performance for Push() in tcp-ping-pong-server Diff since root commit.
Performance for Pop() in tcp-ping-pong-server Diff since root commit.
Performance for Push() in tcp-ping-pong-client Diff since root commit.
Performance for Pop() in tcp-ping-pong-client Diff since root commit.
|
Processing commits from 7f8103a to 2eb73f2 (in the last 15 days) Performance for Push() in tcp-ping-pong-server Diff since root commit.
Performance for Pop() in tcp-ping-pong-server Diff since root commit.
Performance for Push() in tcp-ping-pong-client Diff since root commit.
Performance for Pop() in tcp-ping-pong-client Diff since root commit.
|
Processing commits from 7f8103a to 2eb73f2 (in the last 15 days) Performance for Push() in tcp-ping-pong-server Diff since root commit.
Performance for Pop() in tcp-ping-pong-server Diff since root commit.
Performance for Push() in tcp-ping-pong-client Diff since root commit.
Performance for Pop() in tcp-ping-pong-client Diff since root commit.
|
This PR moves config options out of our network runtime. In the past, the network runtime was responsible for parsing config files into the various config structures (TCP, UDP and ARP), which was not the right place to put it. Now the inetstack is responsible for parsing it's own configuration parameters.