Use Ui32tonum instead of i32tonum #1916
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtariDreams
force-pushed
the
Ui32tonum
branch
3 times, most recently
from
e4cb007
to
e205a65
Compare
AtariDreams
force-pushed
the
Ui32tonum
branch
from
6360ce1
to
5b4508e
Compare
AtariDreams
force-pushed
the
Ui32tonum
branch
from
5b4508e
to
f5cdbd7
Compare
AtariDreams
force-pushed
the
Ui32tonum
branch
3 times, most recently
from
ba3c3ee
to
5aeccc0
Compare
It is more appropriate considering we are dealing with unsigned numbers in the context of the code. Make m_dwWordBitWidth unsigned Also adjust parameter types to accommodate this
AtariDreams
force-pushed
the
Ui32tonum
branch
from
5aeccc0
to
630c354
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is more appropriate considering we are dealing with unsigned numbers in the context of the code.