Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy entire build output before publish #25518

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Copy entire build output before publish #25518

wants to merge 1 commit into from

Conversation

zijchen
Copy link
Member

@zijchen zijchen commented Mar 19, 2024

Address #25517

Recent change in DacFx removed full paths of references from build output. Because ADS copies the dacpac to a temp location before publish (due to a locking issue #11036), this is causing the referenced dacpac to not be found. Fix is to copy the entire output folder which should contain all the necessary references.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8336159731

Details

  • 5 of 8 (62.5%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 41.76%
Changes Missing Coverage Covered Lines Changed/Added Lines %
extensions/sql-database-projects/src/controllers/projectController.ts 5 8 62.5%
Totals Coverage Status
Change from base Build 8333935198: 0.003%
Covered Lines: 30830
Relevant Lines: 69084
💛 - Coveralls

Charles-Gagnon
Charles-Gagnon approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@Charles-Gagnon Charles-Gagnon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to update the extension version as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Charles-Gagnon Charles-Gagnon Charles-Gagnon approved these changes

@kisantia kisantia kisantia approved these changes

@ssreerama ssreerama ssreerama approved these changes

@llali llali Awaiting requested review from llali

@chlafreniere chlafreniere Awaiting requested review from chlafreniere

@Benjin Benjin Awaiting requested review from Benjin Benjin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@zijchen @coveralls @Charles-Gagnon @kisantia @ssreerama