Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][SQL Migration] Target provisioning experience #21782

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

raymondtruong
Copy link
Contributor

@raymondtruong raymondtruong commented Jan 30, 2023

See corresponding sqltoolsservice PR: microsoft/sqltoolsservice#1833

This PR:

  • implements a target provisioning experience, available after generating SKU recommendations which allows the user to generate a provisioning script (currently an ARM template, but can be extended in the future to include Bicep, Terraform, etc)
    • supports quick-start provisioning for all three target platforms, including all prerequisite resources
    • this also allows the user to provision their target with details such as instance name, recommended SKU configuration, and collation matching that of the source (which is a common error) pre-filled
  • adds refresh buttons next to target selection dropdown, for the newly provisioned target, as currently, there's no good way to refresh the list without restarting the wizard
  • fixes an unrelated issue where the SKU recommendation details blade could be opened even if there were no recommendations to show

Screenshots:

  • updated SKU recommendation results view:
    image
  • deployment script blade:
    image
  • Portal template experience:
    todo

@raymondtruong raymondtruong changed the title [WIP][SQL Migration] Integrate target provisioning experience [WIP][SQL Migration] Target provisioning experience Jan 30, 2023
@coveralls
Copy link

coveralls commented Jan 30, 2023

Pull Request Test Coverage Report for Build 4349439127

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 41.94%

Totals Coverage Status
Change from base Build 4348867436: 0.0%
Covered Lines: 28804
Relevant Lines: 63768

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants