New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken links in tool-use.ipynb #2664
base: main
Are you sure you want to change the base?
Fix broken links in tool-use.ipynb #2664
Conversation
Removed unnecessary extra "docs/" which was causing links to be broken. For example, one of the links that was fixed was: https://microsoft.github.io/autogen/docs/docs/tutorial/conversation-patterns#nested-chats Afterwards it is: https://microsoft.github.io/autogen/docs/tutorial/conversation-patterns#nested-chats
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix the error @chi-wai-cheung-mckinsey
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The links work for me at https://microsoft.github.io/autogen/docs/tutorial/tool-use#summary
What is the issue exactly?
@sonichi when using the |
It seems that if the current URL in the browser doesn't have "/" in the end, the original link works. Otherwise, it fails. The proposed change in this PR will fix the issue for the latter but fail for the former. Can we find a solution that works in both cases? |
maybe using an absolute path would solve this issue? |
I thought that a path starting with "/" is an absolute path after the domain name. I don't know why "/docs" is appended. |
Removed unnecessary extra "docs/" which was causing links to be broken.
For example, one of the links that was fixed was: https://microsoft.github.io/autogen/docs/docs/tutorial/conversation-patterns#nested-chats
Afterwards it is:
https://microsoft.github.io/autogen/docs/tutorial/conversation-patterns#nested-chats
Why are these changes needed?
Related issue number
Checks