Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links in tool-use.ipynb #2664

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chi-wai-cheung-mckinsey

Removed unnecessary extra "docs/" which was causing links to be broken.

For example, one of the links that was fixed was: https://microsoft.github.io/autogen/docs/docs/tutorial/conversation-patterns#nested-chats

Afterwards it is:
https://microsoft.github.io/autogen/docs/tutorial/conversation-patterns#nested-chats

Why are these changes needed?

Related issue number

Checks

Removed unnecessary extra "docs/" which was causing links to be broken.

For example, one of the links that was fixed was: https://microsoft.github.io/autogen/docs/docs/tutorial/conversation-patterns#nested-chats

Afterwards it is:
https://microsoft.github.io/autogen/docs/tutorial/conversation-patterns#nested-chats
Copy link
Collaborator

@Hk669 Hk669 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hk669 Hk669 requested review from ekzhu and Hk669 May 11, 2024 18:44
Copy link
Collaborator

@Hk669 Hk669 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the error @chi-wai-cheung-mckinsey

Copy link
Collaborator

@sonichi sonichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The links work for me at https://microsoft.github.io/autogen/docs/tutorial/tool-use#summary
What is the issue exactly?

@Hk669
Copy link
Collaborator

Hk669 commented May 15, 2024

The links work for me at https://microsoft.github.io/autogen/docs/tutorial/tool-use#summary What is the issue exactly?

@sonichi when using the [nested chats](https://microsoft.github.io/autogen/docs/docs/tutorial/conversation-patterns#nested-chats) and [nested chats for tool use](https://microsoft.github.io/autogen/docs/docs/notebooks/agentchat_nested_chats_chess) in the docs, it shows not found.

image

@sonichi
Copy link
Collaborator

sonichi commented May 16, 2024

The links work for me at https://microsoft.github.io/autogen/docs/tutorial/tool-use#summary What is the issue exactly?

@sonichi when using the [nested chats](https://microsoft.github.io/autogen/docs/docs/tutorial/conversation-patterns#nested-chats) and [nested chats for tool use](https://microsoft.github.io/autogen/docs/docs/notebooks/agentchat_nested_chats_chess) in the docs, it shows not found.

image

It seems that if the current URL in the browser doesn't have "/" in the end, the original link works. Otherwise, it fails. The proposed change in this PR will fix the issue for the latter but fail for the former. Can we find a solution that works in both cases?

@Hk669
Copy link
Collaborator

Hk669 commented May 16, 2024

The links work for me at https://microsoft.github.io/autogen/docs/tutorial/tool-use#summary What is the issue exactly?

@sonichi when using the [nested chats](https://microsoft.github.io/autogen/docs/docs/tutorial/conversation-patterns#nested-chats) and [nested chats for tool use](https://microsoft.github.io/autogen/docs/docs/notebooks/agentchat_nested_chats_chess) in the docs, it shows not found.
image

It seems that if the current URL in the browser doesn't have "/" in the end, the original link works. Otherwise, it fails. The proposed change in this PR will fix the issue for the latter but fail for the former. Can we find a solution that works in both cases?

maybe using an absolute path would solve this issue?

@sonichi
Copy link
Collaborator

sonichi commented May 16, 2024

The links work for me at https://microsoft.github.io/autogen/docs/tutorial/tool-use#summary What is the issue exactly?

@sonichi when using the [nested chats](https://microsoft.github.io/autogen/docs/docs/tutorial/conversation-patterns#nested-chats) and [nested chats for tool use](https://microsoft.github.io/autogen/docs/docs/notebooks/agentchat_nested_chats_chess) in the docs, it shows not found.
image

It seems that if the current URL in the browser doesn't have "/" in the end, the original link works. Otherwise, it fails. The proposed change in this PR will fix the issue for the latter but fail for the former. Can we find a solution that works in both cases?

maybe using an absolute path would solve this issue?

I thought that a path starting with "/" is an absolute path after the domain name. I don't know why "/docs" is appended.

@jonrichards jonrichards mentioned this pull request May 25, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants