Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offline agent eval #2607

Merged
merged 28 commits into from May 13, 2024
Merged

Conversation

jluey1
Copy link
Collaborator

@jluey1 jluey1 commented May 6, 2024

Why are these changes needed?

Related issue number

Checks

Copy link

gitguardian bot commented May 6, 2024

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
10404662 Triggered Generic CLI Secret 9a6ecfa .github/workflows/dotnet-release.yml View secret
10404662 Triggered Generic CLI Secret 0e26a9e .github/workflows/dotnet-release.yml View secret
10404662 Triggered Generic CLI Secret 5a3969a .github/workflows/dotnet-release.yml View secret
10404662 Triggered Generic CLI Secret 7e64a96 .github/workflows/dotnet-release.yml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

.github/workflows/contrib-tests.yml Outdated Show resolved Hide resolved
.github/workflows/contrib-openai.yml Outdated Show resolved Hide resolved
@jluey1 jluey1 closed this May 6, 2024
@jluey1 jluey1 reopened this May 6, 2024
@WaelKarkoub
Copy link
Collaborator

Hi @jluey1! Do you have an issue that you are tracking or trying to resolve? If not and if you have time, do you mind updating the PR description, just to give us more context

.github/workflows/contrib-openai.yml Outdated Show resolved Hide resolved
autogen/agentchat/contrib/agent_eval/agent_eval.py Outdated Show resolved Hide resolved
autogen/agentchat/contrib/agent_eval/agent_eval.py Outdated Show resolved Hide resolved
autogen/agentchat/contrib/agent_eval/criterion.py Outdated Show resolved Hide resolved
autogen/agentchat/contrib/agent_eval/criterion.py Outdated Show resolved Hide resolved
autogen/agentchat/contrib/agent_eval/criterion.py Outdated Show resolved Hide resolved
autogen/agentchat/contrib/agent_eval/task.py Outdated Show resolved Hide resolved
test/agentchat/contrib/agent_eval/test_agent_eval.py Outdated Show resolved Hide resolved
@jluey1 jluey1 merged commit 9d7bd26 into microsoft:agenteval_integration May 13, 2024
82 of 97 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants