Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Runtime Logger <> FileLogger #2596

Merged
merged 33 commits into from May 16, 2024
Merged

Custom Runtime Logger <> FileLogger #2596

merged 33 commits into from May 16, 2024

Conversation

Hk669
Copy link
Collaborator

@Hk669 Hk669 commented May 5, 2024

Why are these changes needed?

To support custom logger for the developers.

Related issue number

Issues : #2581

Tasks

  • add the file log functionality to write the logs into a file
  • added the usage to the notebook

Checks

Sample Log Image

image

@codecov-commenter
Copy link

codecov-commenter commented May 5, 2024

Codecov Report

Attention: Patch coverage is 70.70707% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 42.89%. Comparing base (372ac1e) to head (afabe32).
Report is 23 commits behind head on main.

Files Patch % Lines
autogen/logger/file_logger.py 71.59% 21 Missing and 4 partials ⚠️
autogen/logger/logger_factory.py 60.00% 2 Missing ⚠️
autogen/runtime_logging.py 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2596      +/-   ##
==========================================
+ Coverage   33.11%   42.89%   +9.78%     
==========================================
  Files          86       87       +1     
  Lines        9108     9336     +228     
  Branches     1938     2139     +201     
==========================================
+ Hits         3016     4005     +989     
+ Misses       5837     4958     -879     
- Partials      255      373     +118     
Flag Coverage Δ
unittest 12.70% <29.29%> (?)
unittests 42.19% <70.70%> (+9.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hk669
Copy link
Collaborator Author

Hk669 commented May 5, 2024

@ekzhu do we need different files for logs? as we have a different tables in SqliteLogger.

@ekzhu ekzhu enabled auto-merge May 16, 2024 05:43
Copy link
Collaborator

@krishnashed krishnashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compared it with the default sqlite logger, looks good to be merged!

@ekzhu ekzhu added this pull request to the merge queue May 16, 2024
Merged via the queue into main with commit d461100 May 16, 2024
79 of 93 checks passed
@ekzhu ekzhu deleted the runtime-log branch May 16, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants