[Bug] Add Azure-hosted Dalle Image Generation Support #2586
Conversation
|
The failing compressible agent tests is not caused by this PR. |
| @@ -287,5 +299,9 @@ def _validate_resolution_format(resolution: str): | |||
|
|
|||
|
|
|||
| def _validate_dalle_model(model: str): | |||
| if model not in ["dall-e-3", "dall-e-2"]: | |||
| raise ValueError(f"Invalid DALL-E model: {model}. Must be 'dall-e-3' or 'dall-e-2'") | |||
| if model not in VALID_DALLE_MODELS: | |||
There was a problem hiding this comment.
For Azure models, they are not necessarily named as one of VALID_DALLE_MODELS. They can be named as anything.
| @@ -108,6 +114,12 @@ def cache_key(self, prompt: str) -> str: | |||
| keys = (prompt, self._model, self._resolution, self._quality, self._num_images) | |||
| return ",".join([str(k) for k in keys]) | |||
|
|
|||
| def _dalle_client_factory(self, dalle_config: Dict) -> Union[OpenAI, AzureOpenAI]: | |||
| if dalle_config.get("api_type") == "azure": | |||
| return AzureOpenAI(api_key=dalle_config["api_key"]) | |||
There was a problem hiding this comment.
AzureOpenAI requires more fields than api_key.
| if dalle_config.get("api_type") == "azure": | ||
| return AzureOpenAI(api_key=dalle_config["api_key"]) | ||
| else: | ||
| return OpenAI(api_key=dalle_config["api_key"]) |
There was a problem hiding this comment.
For OpenAI, I'm not sure if more keys are possible. Why do we pass the api_key only here?
|
@sonichi @BeibinLi thank you for the reviews! Initially, I assumed that OpenAI and AzureOpenAI were identical. I’ve been attempting to get access to Azure OpenAI APIs, but it seems like I need a corporate account/email. As I’m unable to test these changes locally I’ll keep this PR in draft until I manage to access Azure OpenA. |
This PR adds support for Dalle image generation hosted on Azure.
Why are these changes needed?
Related issue number
Closes #2510
Checks