New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced Type Hints for Improved Readability and Maintainability: Addressing Type Mismatch in query_quadrant
Return Statement
#2452
base: main
Are you sure you want to change the base?
Conversation
@sonichi i've no idea why the compression test is failing, which isn't relevant to this PR. maybe because of the previous commits? |
@yiranwu0 @WaelKarkoub @gagb is it time to retire compressible agent? Have we reached feature parity with the |
@sonichi I'm working on LLMLingua support, once that goes in, we should retire compressible agent. #2225 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the code with a source url, shall we keep as original?
Another issue is that this file is not covered by test right now because the test that covered this file in v0.1 hasn't been migrated to v0.2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think, these changes are required if, these utils are being used in any of our modules or the developer. there are some return types to be updated, which is mentioned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sonichi shall i cover the tests for the utils in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's possible that we'll deprecate this util file. It's better to avoid changes to this file in this PR, especially the code which contains a source url.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure @sonichi , lets not make changes anymore to this file. Thanks
Why are these changes needed?
I've updated the type hints of the
*_utils
to improve code readability, maintainability, and to facilitate static type checking. This enhancement will make it easier for developers to understand the expected types of parameters and return values, reducing the likelihood of type-related errors and improving overall code quality.updated the
query_quadrant
inqdrant_retrieve_user_proxy_agent.py
, the return statement doesn't match with the type mentioned. otherwise returns adict
, could be a problem for the developer to usequery_quadrant
.Related issue number
No issue is related.
Checks