Preserve type nodes which resolve to errors in declaration emit output #58475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
weswigham
commented
May 8, 2024
| @@ -146,7 +146,7 @@ declare function flatMap(): any; | |||
| * @template T | |||
| * @type {Call<T>} | |||
| */ | |||
| declare const identity: any; | |||
| declare const identity: Call<T>; | |||
There was a problem hiding this comment.
There's a Type Call is not generic error on the input here, so the output is fairly flexible. Preserving the erroneous input node is fine, since it's what isolatedDeclarations wants.
jakebailey
approved these changes
May 8, 2024
weswigham
deleted the
preserve-unresolved-error-type-nodes-in-declaration-emit
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58430
Like #58428, this takes a case where the checker usually issues an error and blocks declaration emit and adjusts the output to match what
isolatedDeclarationusers expect - retaining the input type node (note that I've flagged this behind the flag I added in #58428 (and renamed that flag to be a bit more general) so error messages will still printanyinstead of whatever node produced the error).I actually had this change in one of my older omnibus node builder improvement PRs, but it got lost when I was breaking things up to be more reviewable.