Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused SymbolLinks properties #58393

Merged
merged 1 commit into from May 10, 2024

Conversation

JoostK
Copy link
Contributor

@JoostK JoostK commented May 1, 2024

I was going over some code over the weekend and hit various unused/unassigned SymbolLinks field declarations.

  • The properties outerTypeParameters, aliasSymbol and aliasTypeArguments are stored on Type, not SymbolLinks (I'm guessing they used to be stored in SymbolLinks?)
  • exportsSomeValue is entirely unused
  • enumKind is used, but never assigned to so essentially all surrounding logic is dead.

Similar to #58377

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label May 1, 2024
@typescript-bot
Copy link
Collaborator

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

@JoostK
Copy link
Contributor Author

JoostK commented May 1, 2024

Feel free to close if this introduces undesirable churn.

@jakebailey jakebailey requested a review from weswigham May 1, 2024 20:51
Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me, unless not storing things here is an oversight and we shouldn't have moved them away.

@jakebailey jakebailey merged commit 0b37062 into microsoft:main May 10, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants