WIP: [ci] [R-package] re-enable 'rchk' checks

.ci/setup.sh

@@ -145,7 +145,7 @@ else # Linux
  fi
 fi
 
-if [[ "${TASK}" != "r-package" ]] && [[ "${TASK}" != "r-rchk" ]]; then
+if [[ "${TASK}" != "r-package" ]]; then
  if [[ $SETUP_CONDA != "false" ]]; then
  sh miniforge.sh -b -p $CONDA
  fi

.ci/test.sh

@@ -20,7 +20,7 @@ if [[ $IN_UBUNTU_BASE_CONTAINER == "true" ]]; then
  export LC_ALL="en_US.UTF-8"
 fi
 
-if [[ "${TASK}" == "r-package" ]] || [[ "${TASK}" == "r-rchk" ]]; then
+if [[ "${TASK}" == "r-package" ]]; then
  bash ${BUILD_DIRECTORY}/.ci/test_r_package.sh || exit 1
  exit 0
 fi

.ci/test_r_package.sh

@@ -110,12 +110,7 @@ fi
 
 # Manually install Depends and Imports libraries + 'knitr', 'markdown', 'RhpcBLASctl', 'testthat'
 # to avoid a CI-time dependency on devtools (for devtools::install_deps())
-# NOTE: testthat is not required when running rchk
-if [[ "${TASK}" == "r-rchk" ]]; then
- packages="c('data.table', 'jsonlite', 'knitr', 'markdown', 'Matrix', 'R6', 'RhpcBLASctl')"
-else
- packages="c('data.table', 'jsonlite', 'knitr', 'markdown', 'Matrix', 'R6', 'RhpcBLASctl', 'testthat')"
-fi
+packages="c('data.table', 'jsonlite', 'knitr', 'markdown', 'Matrix', 'R6', 'RhpcBLASctl', 'testthat')"
 compile_from_source="both"
 if [[ $OS_NAME == "macos" ]]; then
  packages+=", type = 'binary'"
@@ -151,29 +146,6 @@ elif [[ $R_BUILD_TYPE == "cran" ]]; then
 
  ./build-cran-package.sh || exit 1
 
- if [[ "${TASK}" == "r-rchk" ]]; then
- echo "Checking R package with rchk"
- mkdir -p packages
- cp ${PKG_TARBALL} packages
- RCHK_LOG_FILE="rchk-logs.txt"
- docker run \
- -v $(pwd)/packages:/rchk/packages \
- kalibera/rchk:latest \
- "/rchk/packages/${PKG_TARBALL}" \
- 2>&1 > ${RCHK_LOG_FILE} \
- || (cat ${RCHK_LOG_FILE} && exit 1)
- cat ${RCHK_LOG_FILE}
-
- # the exceptions below are from R itself and not LightGBM:
- # https://github.com/kalibera/rchk/issues/22#issuecomment-656036156
- exit $(
- cat ${RCHK_LOG_FILE} \
- | grep -v "in function strptime_internal" \
- | grep -v "in function RunGenCollect" \
- | grep --count -E '\[PB\]|ERROR'
- )
- fi
-
  # Test CRAN source .tar.gz in a directory that is not this repo or below it.
  # When people install.packages('lightgbm'), they won't have the LightGBM
  # git repo around. This is to protect against the use of relative paths

.ci/test_r_package_rchk.sh

@@ -0,0 +1,31 @@
+#!/bin/bash
+
+set -E -e -u -o pipefail
+
+echo "Checking R package with rchk"
+sh build-cran-package.sh --no-build-vignettes
+
+mkdir -p ./packages
+LGB_VER=$(head -1 VERSION.txt | sed "s/rc/-/g")
+PKG_TARBALL="lightgbm_${LGB_VER}.tar.gz"
+cp ./${PKG_TARBALL} ./packages/${PKG_TARBALL}
+
+RCHK_LOG_FILE="rchk-logs.txt"
+run_rchk() {
+ docker run \
+ --rm \
+ --env MAKEFLAGS="-j2" \
+ -v $(pwd)/packages:/rchk/packages \
+ kalibera/rchk:latest \
+ "/rchk/packages/${PKG_TARBALL}"
+}
+run_rchk 2>&1 | tee ${RCHK_LOG_FILE} | cat || (cat ${RCHK_LOG_FILE} && exit 1)
+
+# the exceptions below are from R itself and not LightGBM:
+# https://github.com/kalibera/rchk/issues/22#issuecomment-656036156
+exit $(
+ cat ${RCHK_LOG_FILE} \
+ | grep -v "in function strptime_internal" \
+ | grep -v "in function RunGenCollect" \
+ | grep --count -E '\[PB\]|ERROR'
+)