Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tree): use SharedTree format version 3 by default #21157

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yann-achard-MS
Copy link
Contributor

Description

Makes SharedTreeFormatVersion.v3 the default value.

Breaking Changes

This is a breaking change in the sense that it breaks collaboration with versions of SharedTree before v3 format was implemented (i.e. anything rc-3 and earlier).

We are leveraging the fact that SharedTree doesn't yet have as strong of compatibility guarantees as other DDSes with current production usage.

@github-actions github-actions bot added area: dds Issues related to distributed data structures area: dds: tree public api change Changes to a public API base: main PRs targeted against main branch labels May 18, 2024
@msfluid-bot
Copy link
Collaborator

@fluid-example/bundle-size-tests: +164 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 453.98 KB 453.98 KB No change
azureClient.js 551.23 KB 551.23 KB No change
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 257.82 KB 257.82 KB No change
fluidFramework.js 356.74 KB 356.82 KB +82 Bytes
loader.js 132.91 KB 132.91 KB No change
map.js 41.45 KB 41.45 KB No change
matrix.js 143.67 KB 143.67 KB No change
odspClient.js 519.76 KB 519.76 KB No change
odspDriver.js 97.29 KB 97.29 KB No change
odspPrefetchSnapshot.js 42.15 KB 42.15 KB No change
sharedString.js 160.19 KB 160.19 KB No change
sharedTree.js 356.73 KB 356.81 KB +82 Bytes
Total Size 3.19 MB 3.19 MB +164 Bytes

Baseline commit: 3eb328b

Generated by 🚫 dangerJS against 94cee4b

@yann-achard-MS yann-achard-MS marked this pull request as ready for review May 20, 2024 17:13
@yann-achard-MS yann-achard-MS requested a review from a team as a code owner May 20, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dds: tree area: dds Issues related to distributed data structures base: main PRs targeted against main branch public api change Changes to a public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants