refactor(tree) use separate cells ids for src and dst cells in moves #21156
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before this PR, we used to use assign the same identifiers to cells emptied by a move's detach and cells filled by a move's attach.
This is a problem because, when such a move is rolled back, the inverse move would keep those cell IDs the same, leading to a situation where different cells had been assigned the same identifier over time. This is an unnecessary complication that may cause bugs.
This PR allocates separate IDs for source and destination cells (using sequential IDs for neighboring cells).
The ID associated with the overall move (which is used to link the source and destination marks) gets assigned the same ID as the detached cell (except when the detach comes with an override).
Breaking Changes
None. The way edits are processed has not changed.