refactor(lambdas): Upgrade eslint config to "recommended" and fix violations in code #21155
Conversation
github-actions
bot
added
area: server
| @@ -62,7 +62,7 @@ export class BroadcasterLambda implements IPartitionLambda { | |||
| private readonly clientManager: IClientManager | undefined, | |||
| ) {} | |||
|
|
|||
| public async handler(message: IQueuedMessage) { | |||
| public async handler(message: IQueuedMessage): Promise<undefined> { | |||
There was a problem hiding this comment.
Seems like this should be Promise<void> and remove the return?
There was a problem hiding this comment.
Yeah, this seemed very strange. Initially I was leaning towards avoiding any disruption here, but this seems safe enough to clean up. Will do.
There was a problem hiding this comment.
Actually, this does seem to be intentional, based on usage patterns. I've updated the docs in IPartitionLambda to call out what's going on, and annotated the implementations with @inheritDoc comments to help signal that the specialness is documented.
This pattern seems odd to me, and could probably be improved, but it does appear to have been intentional and is not as simple as simply changing the return types to void.
Edit: the general pattern is intentional. This specific return type was incorrect. It is async, so it should have been Promise<void>. This has been resolved here.
| } else if ( | ||
| value.operation.type === MessageType.ClientJoin && | ||
| this.localCheckpointEnabled | ||
| ) { | ||
| this.globalCheckpointOnly = false; |
There was a problem hiding this comment.
I think I'd revert this and disable the lint rule locally to keep the if-else structure just with the value.operation.type checks.
…lations in code (microsoft#21155) The minimal config is deprecated and scheduled for deletion. Updates the package to use the "recommended" config and fixes violations in code. Disabled a number of rules in the config due to the sheer number of violations. These can (and should) be fixed at a later date. [AB#8002](https://dev.azure.com/fluidframework/235294da-091d-4c29-84fc-cdfc3d90890b/_workitems/edit/8002)
The minimal config is deprecated and scheduled for deletion. Updates the package to use the "recommended" config and fixes violations in code.
Disabled a number of rules in the config due to the sheer number of violations. These can (and should) be fixed at a later date.
AB#8002