[SPIR-V] Remove always disabled test #6634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was marked DISABLED_ in Gtest at the time it was added in PR microsoft#3155, so it appears that it was never passing. I don't think it's a high-priority to implement at this point, so opting to simply remove it. This is the last test in the unsupported directory so it can now be removed entirely. Fixes microsoft#6616
s-perron
approved these changes
May 17, 2024
Keenuts
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was marked DISABLED_ in gtest at the time it was added in PR #3155, so it appears that it was never passing. Specifically, the CHECK for
DebugFunction [[func1]]fails. I don't think it's a priority to implement debug info for unreferenced functions at this point, so opting to simply remove it.This is the last test in the unsupported directory so it can now be removed entirely.
Fixes #6616