Add constant evaluation for fmod to CodeGen #6411
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you use literals with fmod, it generates the hl intrinsic usind double. During HLOperationLower, this expands to several operations, including DXIL FRC intrinsic. FRC intrinsic doesn't support double, so GetOpFunc returns nullptr for the overload. nullptr is blindly used in CreateCall, which crashes trying to deref nullptr. This change fixes the literal case by adding constant eval to CodeGen for this intrinsic. It will still crash if non-constant doubles are used explicitly. Fixing that will require a special path in HLOperationLower to change the generated instruction sequence to something compatible with double.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you use literals with fmod, it generates the hl intrinsic usind double. During HLOperationLower, this expands to several operations, including DXIL FRC intrinsic. FRC intrinsic doesn't support double, so GetOpFunc returns nullptr for the overload. nullptr is blindly used in CreateCall, which crashes trying to deref nullptr.
This change fixes the literal case by adding constant eval to CodeGen for this intrinsic.
It will still crash if non-constant doubles are used explicitly. Fixing that will require a special path in HLOperationLower to change the generated instruction sequence to something compatible with double.
Fixes #6410.