Cherrypick fixes for 6223 and 6168 to release branch. #6340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More testing of node shader objects passed as arguments. noinline and export still not work, added as XFail. For microsoft#6124 (cherry picked from commit 13609db)
…rdPtrAndUpdateUsers (microsoft#6314) In EmitGetNodeRecordPtrAndUpdateUsers, the type will be mutated. And the GEP user of the RecordPtr will be merged at same time. This make things complex because the GEP index need to be updated since type is mutated. To make things easier, merge the GepUse after mutate type. Fixes microsoft#6223 (cherry picked from commit 823125b)
Add lit.local.cfg to set unsupported when not dxil-1-8. (cherry picked from commit 76f00d0)
Replace assert on illegal DXIL op with return illegal value. Check the illegal cases in validation. Fixes microsoft#6168 (cherry picked from commit 5dee81c)
This will allow lit test check dxil version to avoid running on unsupported dxil.dll. (cherry picked from commit 4c4a588)
Check dxc version and dxil version separately. (cherry picked from commit 5e658ac)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other PRs are for lit which enables dxil version check so the tests could be skipped for older dxil.dll.