Add alignment to NodeRecordType in RDAT only #6278
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the Python code formatter. |
tex3d
force-pushed
the
rdat-record-alignment-no-meta
branch
3 times, most recently
from
7e48893
to
c9b8466
Compare
tex3d
force-pushed
the
rdat-record-alignment-no-meta
branch
from
c9b8466
to
1acf3ff
Compare
tex3d
force-pushed
the
rdat-record-alignment-no-meta
branch
from
1acf3ff
to
0df184e
Compare
Since DxilValidation for RDAT part expects exact binary comparison match, we need to restore any missing alignment from the RDAT before we generate RDAT and compare. Alignment for records used with GetNodeRecordPtr() will be restored from llvm, and not overwritten by this alignment from RDAT, so it still varifies that alignment matches type llvm module when available.
tex3d
force-pushed
the
rdat-record-alignment-no-meta
branch
from
0df184e
to
4eb1d2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds NodeRecordType alignment field to RDAT to make it possible to validate pointer and stride alignment in the runtime.
This version of the change avoids changing any DXIL metadata, requiring recovery of alignment information on DxilModule load from the record type used with GetNodeRecordPtr(). If a record is not used in the code, alignment will not be recovered.
Issue: #6270