[CMAKE] Cleanup logic for enabling SPIR-V #6112
Open
+13
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keenuts
approved these changes
Dec 20, 2023
s-perron
approved these changes
Jan 15, 2024
|
The changes look good to me. I cannot see why the bots failed. |
This just cleans up the logic for enabling and disabling building SPIR-V and the SPIR-V tests. It is _extremely_ unusable to ignore a user-defined value that is specified as an option. In the current code if a user enables SPIR-V tests but disables SPIR-V codegen, the user-specified option to enable codegen gets ignored.
llvm-beanz
force-pushed
the
cbieneman/cmake-spirv-cleanup
branch
from
791071d
to
7214e7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just cleans up the logic for enabling and disabling building SPIR-V and the SPIR-V tests. It is extremely unusable to ignore a user-defined value that is specified as an option. In the current code if a user enables SPIR-V tests but disables SPIR-V codegen, the user-specified option to enable codegen gets ignored.