Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support TagsOnly mode with DependsOnTags #535

Open
gfs opened this issue Mar 8, 2023 · 1 comment
Open

Support TagsOnly mode with DependsOnTags #535

gfs opened this issue Mar 8, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@gfs
Copy link
Contributor

gfs commented Mar 8, 2023

Is your feature request related to a problem? Please describe.
TagsOnly mode currently is not compatible with the DependsOnTags feature. This is because TagsOnly mode does not collect the full match data necessary for the current DependsOnTags implementation.

Describe the solution you'd like
TagsOnly mode could collect tags as a mapping between Tags and a List of rules that apply that tag. When entering depends on checking, if in tags only mode we can perform a similar rule removing process with recalculating the tags.

Describe alternatives you've considered
Full match data could still be gathered and just discarded later instead, but this will negatively impact performance.

@gfs gfs added the enhancement New feature or request label Mar 8, 2023
@gfs
Copy link
Contributor Author

gfs commented Mar 9, 2023

This is too complex to do without rethinking the metadata helper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant