Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor MetaDataHelper #536

Open
gfs opened this issue Mar 9, 2023 · 1 comment
Open

Refactor MetaDataHelper #536

gfs opened this issue Mar 9, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@gfs
Copy link
Contributor

gfs commented Mar 9, 2023

The metadata helper is too complex and inflexible. Significant changes should be made to simplify - like holistically collecting everyhing for "metadata" rather than having magic value fields in the metadata helper - magic values can be chosen for the specific report instead. this would also enable doing the TagsOnly mode with DependsOn per #535

@gfs gfs added the enhancement New feature or request label Mar 9, 2023
@gfs
Copy link
Contributor Author

gfs commented Mar 16, 2023

Potential ideas:

  1. Collect all matches during the run, at the end of the run do depends on processing, then overrides processing, then send the matches to metadata helper to generate the tags. One complication here is the MaxNumMatches mode which requires counting the tags as matches are made. And TagsOnly mode which does not collect matches currently.
  2. Rethink how/when Exerpts and samples are taken. Currently they are gathered as part of the match, but if matches are discarded before return to the user the extra time to allocate the data for the strings is a waste. A complication here is a sample needs to be taken from the file Stream which may not relate directly to a file on disk (i.e. may have been a file found inside an archive via recursive extractor)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant