Skip to content
This repository has been archived by the owner on Dec 29, 2023. It is now read-only.

Add ingress yaml for GKE #737

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add ingress yaml for GKE #737

wants to merge 1 commit into from

Conversation

bia
Copy link

@bia bia commented Sep 11, 2017

Though there is not yet a tutorial for this, the sock shop cannot run on GKE without this file (and some changes to front-end-svc.yaml
detailed here).

Adding it would make the install easier and I don't think it would introduce problems with other platforms.

Though there is not yet a tutorial for this, the sock shop cannot run
on GKE without this file (and some changes to front-end-svc.yaml
detailed here
https://docs.google.com/document/d/1gWaM_wd-4kkmsf2j_LHJ8ICrGCgTgcLNf5EF
eapDeWg/edit?usp=sharing)
@etiennetremel
Copy link
Contributor

Hi @bia, seems that you are using an old version of the sock shop. In June @mongrelion made a change to the service (see 3a01f33#diff-e710cec8113ed34b8d2b9bf470ba8a5c) and switched the service type NodePort to LoadBalancer which is then processed by GKE to provide an external IP.

@bia
Copy link
Author

bia commented Oct 5, 2017

Hi @etiennetremel, that's right, I went through the GKE setup in June when I joined Weaveworks, probably just before the changes were made.
To make it work (shown in the document that I linked to) I also had to change the service type NodePort to LoadBalancer. That doesn't seem compatible with the Digital Ocean sock shop tutorial, which is why I didn't include it in the PR..
Overall, it seems to me that having an ingress is recommended?

@etiennetremel
Copy link
Contributor

In this case it makes sense, I noticed that other provider like GiantSwarm also doesn't support service type LoadBalancer and you have to specify the host as folllow: host: <yourchoice>.<cluster-id>.k8s.gigantic.io.

@bia
Copy link
Author

bia commented Oct 5, 2017

So perhaps it should changed back to NodePort?

@etiennetremel
Copy link
Contributor

etiennetremel commented Oct 6, 2017

We can keep it in the directory, but because this is specific per provider we need to add extra documentation on how and why you should use it instead of the NodePort. The current implementation is the correct one if you follow the tutorial.

@vlal-zz
Copy link
Contributor

vlal-zz commented Nov 1, 2017

@bia @etiennetremel if this doesn't break any other deployment I'm happy to add it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants