Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable wide Unicode support for names #24
base: main
Are you sure you want to change the base?
Enable wide Unicode support for names #24
Changes from 2 commits
b34ad7a
ebd55c3
e03860c
d9b89e5
c400dab
f4ec634
54f041d
4785fba
73eb92a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn’t dashes also be edge characters?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you mean allowed edge characters, it was forbidden by the spec previously. I kept it but I don't mind changing.
Currently, the name cannot either start or end with any punctuation or underscore.
Is this something you suggest to change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To refresh my memory: So, in
name
, this last stuff is about what is possible to exit after.That behavior at the end is very different from whether the first character is allowed to start a name.
Before, there was a very different check compared to the check in
start
:-
and_
were allowed in names but not at the end.Now they’re the same. I’m not sure if that’s useful? Perhaps the last line should just be
return ok(code)
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tried
return ok(code)
at the end. Allowing the name to end with an underscore interferes with emphasis notation. I reverted the commit.I think, there is no point to allow punctuation in the end but don't allow at the start. If we are going to allow punctuation, it should be (almost) equal.
Possible options:
=
,~
(special in some flavours),_
,*
, parentheses and perhaps some more — basically anything in the ASCII (in comparison to option 3, blacklist under 128).