Screen height on tablet vs keyboard #1162
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aim
Previously (https://github.com/microbit-foundation/python-editor-v3/issues/11), "If we stick with a bottom toolbar then the keyboard on iPad is problematic. On Android the viewport resizes. On iOS it's overlapped."
This PR aims to update the tablet UI behaviour such that the keyboard now overlays the UI for iOS and Android. This behaviour is alines with the keyboard experiences in the Raspberry pi and MakeCode editor.
In the instance where the height is shorter than what the sidebar allows, the entire UI will become scrollable in the Y-direction such that the min-height of the UI is the height of the side bar.
In the instance where the width is shorter than what the simulator width + sidebar width allows, the entire UI will become scrollable in the X-direction such that the min-width will be simulator width + sidebar width.
Still to do
To do for future