Update libraries to latest versions and Svelte to next.120 #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed to disable using the Nav component. Error was `ReferenceError: Nav is not defined`
|
Thanks for putting his together. Would be good to keep the Nav in. Does it help if you remove the ts declaration? Weird it’s saying it’s just not defined. |
|
Sure, and good idea! Removing |
|
next.121 still errors. This is likely the issue to track for this: sveltejs/svelte#11429 |
|
How does it look using just 120? |
|
120 looked ok and now 123 has fixed the other problem! I haven't checked every page, but examples, components work. Looking good! |
|
Very cool thanks! I'll merge this into the svelte-5 branch and then figure out a plan for merging that branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried running the Layercake repo with an update to the Svelte 5 release candidate. I managed to get it to run with
next.120.However, I had to disable using the
Navcomponent in the main+layout.svelte.Error was
ReferenceError: Nav is not definedI had this error as well when I had tried this with an earlier pre-release (<next.100 IIRC).
The components and examples seem to run fine at first looking around. That's great as it would mean that the library (given Svelte 5's promise for compatibility with the old APIs) should (mostly?) just work.
So I guess it's about getting the website itself to run.
When I update to next.120 the Layercake website disappears after an initial load.
The console error message is