Faster keywordize #506
Open
Faster keywordize #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ikitommi do you want to extend this solution to cljs or keep it just for clj? |
bsless
force-pushed
the
faster-keywordize
branch
from
e789140
to
1a0f1d3
Compare
|
Decided to split the implementation off only for Clojure since cljs is built differently, don't even know how |
|
@ikitommi are there any blocking items for a review? I'd be happy to clear them if so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement walk with protocols and keywordize keys with it.
Gives about 2x speedup
left to do: decide on an implementation for cljs