New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.x] Update Node 20.12.2, Npm 10.5.0 and Typescript 5.4.5 (Dev bundle 20.12.2.0) #13090
base: release-3.0
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for v3-meteor-api-docs canceled.
|
you need to build a new dev bundle btw |
Node 20.13.0 is out: |
The latest release of Node has some reverse on Windows stuff: |
Thanks! Once CI responds sucessfully after recent Windows environment failures, we can proceed to 20.13.1. There are still unresolved issues with using the The current problem is that CI environment don't consistently give the same success as local environment. We consider migrating to GitHub Actions using a custom runner to have greater control over the environment and see the check green at last. |
Tests pass 🟢! To summarize what happened in this PR:
|
OSS-386
OSS-385
Summary of this PR here
Fix on Windows tests
After the 20.12.2 node.js updates, calling
spawn
with a .cmd or .bat file requires theshell: true
option. This PR adjusts our usage accordingly.Update
Tests are fixed on Windows as seen on this picture:
However, it doesn't finish properly reaching this code, and it times out at the end.
And locally, I can't seem to reproduce the same, locally it finishes properly.
Trying to debug the code around spawn of child processes, since maybe one is never stop after last adjusts. But hard to verify it since locally behaves differently.