Feature/underscore 1.9.2 #12994
Open
Feature/underscore 1.9.2 #12994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now that 1.7 is working, I'll try to push a few more version up. |
Need to test how Meteor reacts to the new isArrayLike which seem to fix the original problem there was in underscore in Meteor. Right now this new function and the original Meteor fix have mixed use through the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #12912
Upgrading underscore to v1.8.3 while keeping Meteor specific changes. Though from looking at the issue in underscore it should have been fixed, so there might be something more going on here:
jashkenas/underscore#770
More context: #594