Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meteor-embedded underscore library contains vulnerabilities #12673

Open
carlosalvidrez opened this issue Jun 12, 2023 · 12 comments · May be fixed by #12994
Open

Meteor-embedded underscore library contains vulnerabilities #12673

carlosalvidrez opened this issue Jun 12, 2023 · 12 comments · May be fixed by #12994
Assignees
Milestone

Comments

@carlosalvidrez
Copy link

Hi guys, is there a way for me to upgrade the meter/underscore library to a more modern version? The one that seems to be bundled with meteor 2.12 is being reported by Chrome's Lighthouse as vulnerable (attached screenshot).

Meteor Version 2.12.
Chrome Lighthouse inspection reports a vulnerability in the underscore library.
I have it added as "underscore" in the packages file.

image

@jamauro
Copy link
Contributor

jamauro commented Jun 12, 2023

There was an effort to remove underscore. See: https://github.com/meteor/meteor/pulls?q=is%3Apr+is%3Aopen+remove+underscore

Sounds like those PRs should be merged

@carlosalvidrez
Copy link
Author

Thanks @jamauro ... I am also using the library on some of my custom code routines... do you have any suggestion as to a good replacement library? Unless newer versions of underscore, that are not vulnerable, are available, I might have to switch. Thanks

@jamauro
Copy link
Contributor

jamauro commented Jun 13, 2023

Take a look at lodash or you might be able to just use native JS https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore

@StorytellerCZ StorytellerCZ added the good first issue Good first issue or something that should is nice to do. label Sep 27, 2023
@StorytellerCZ
Copy link
Collaborator

@Grubba27 I think we need to merge as many of the remove underscore PRs as possible for the next release. In the meantime I will update our version of underscore to the latest release before underscore was split from the single file. Already got v1.6 done.

Just a note to everyone, Meteor has adjusted underscore in small parts so that needs to be taken into account when doing these upgrades and sadly it isn't as simple as just upping a version number.

@StorytellerCZ
Copy link
Collaborator

@carlosalvidrez do you know what minimum underscore version we need to clear the warning?

@carlosalvidrez
Copy link
Author

Hi @StorytellerCZ! It's this:

[email protected]

@StorytellerCZ
Copy link
Collaborator

StorytellerCZ commented Sep 27, 2023

@carlosalvidrez that is strange 1.5.2 > 1.0.13

If it is 1.13.0, then that would make sense, but that one will be quiet difficult as I think that is after the split into multiple packages.

I can upgrade up to 1.12.1 reasonably. After that it will become more difficult.

UPDATE: 1.9.2 is more realistic target as the first step, as that is the latest version similar to what we have in Meteor.

@carlosalvidrez
Copy link
Author

Yes, it's strange, puzzled as to why Chrome detects 1.5.2... weird!
Perhaps it's a duplicate dependency of an npm package?

The version I quoted above is from the meteor "packages" file.

@StorytellerCZ
Copy link
Collaborator

The Meteor packages internally uses underscore 1.5.2.

@StorytellerCZ StorytellerCZ self-assigned this Sep 27, 2023
@StorytellerCZ StorytellerCZ removed the good first issue Good first issue or something that should is nice to do. label Sep 27, 2023
@Grubba27
Copy link
Contributor

Hey @StorytellerCZ, I agree! could you tag those green underscore PRs so we can work on them for the 2.14 release?

@StorytellerCZ
Copy link
Collaborator

I'll add them to the milestone.

@StorytellerCZ
Copy link
Collaborator

Meteor 2.15, updates underscore package to 1.6 (after that I'm having some issues which I need to debug). Will look if there is some other place where we get underscore.

@StorytellerCZ StorytellerCZ linked a pull request Feb 5, 2024 that will close this issue
@denihs denihs modified the milestones: Release 2.16, 2.17 May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants