Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Programmable Print Editions #101

Merged
merged 3 commits into from
Mar 10, 2024
Merged

Fix Programmable Print Editions #101

merged 3 commits into from
Mar 10, 2024

Conversation

kstepanovdev
Copy link
Contributor

No description provided.

@kstepanovdev kstepanovdev added the bug Something isn't working label Mar 8, 2024
@kstepanovdev kstepanovdev self-assigned this Mar 8, 2024
blockiosaurus
blockiosaurus requested changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@blockiosaurus blockiosaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe there's one more missing match statement in the Update flow but otherwise this is perfect!

mpl-token-metadata/programs/token-metadata/program/src/processor/metadata/update.rs

Line 232 in cb49f6b

if matches!(token_standard, TokenStandard::ProgrammableNonFungible) {

@kstepanovdev kstepanovdev merged commit 609afd2 into main Mar 10, 2024
9 checks passed
@kstepanovdev kstepanovdev deleted the fix-pnft-editions branch March 10, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blockiosaurus blockiosaurus blockiosaurus approved these changes

@nhanphan nhanphan Awaiting requested review from nhanphan

@danenbm danenbm Awaiting requested review from danenbm

Assignees

@kstepanovdev kstepanovdev

Labels
bug Something isn't working
Projects
Metaplex
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kstepanovdev @blockiosaurus