Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Admin Page frontend #67
base: main
Are you sure you want to change the base?
Create Admin Page frontend #67
Changes from 4 commits
169a92e
296487d
80d6869
f257382
2502fdb
3e99bc1
fb7e0cd
f25ab6a
2aee86f
2020b61
bdcc5c6
c752a85
f2ed571
cfda5c8
319e80b
04b445e
6573b91
01f08a7
fdd6600
42ace0c
2fb2586
5914320
a9ac6e1
54190b6
3e0de42
94d1321
12583a6
2d3bad5
f57c7ad
108c3b0
4feb80e
5d5fc97
f0155e1
2b1e25a
c8fdb1b
7a90ade
4ee3a3e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can make these select inputs since they only have a few options.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done, however I haven't been able validate that the course_code and course_name match
one idea I had was to have the course_name display the value from the courses.json file for the corresponding key, this should be doable using the format method in solid-select, however I wasn't able to figure it out. some help with that would be quite nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we really need an "edit mode" for the entire page. We can have an edit button per paper that opens a modal that will have a form for editing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'll implement this once i make the modal to view the pdf, until then if we're just using the new tab link functionality i feel like being able to see all the question papers together will make the process faster
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, true. In that case, instead of an edit mode, make an edit button that becomes enabled if something is changed. Clicking on it will update the data on the backend.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isEditMode is removed
i'm still not very happy with my current approve/reject functionality, what other methods would you suggest, keeping in mind speed of approval?
is a button fine?
do we need further confirmation before approval?
how can i make this process faster and error free?
these are some questions I need to answer before I completely fix this, until then I'll make the table sortable