New Shape; Horn #76
Open
New Shape; Horn #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Composite shapes use volume to find Z. Shapes with closed paths ignore doubled final point when averaging Z.
jslint doesn't complain anymore. Vector class has useful isSame function.
Actually "truncated cone with spherical caps" but that's a mouthful.
frontDiameter and endDiameter can actually be changed, now.
|
Add a 👍 reaction to this issue if you would like to see this feature added. Do not add +1 comments — They will be deleted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a truncated-cone-with-spherical-caps Shape, to which I've given the slightly easier to type name Horn. It is much like a Cone or a Cylinder but each of the ends can have their diameter set independently using
frontDiameterandrearDiameter. It should be useful in creating more organic models.I tried to follow the architecture of similar Shapes but I'm not sure I succeeded in making it readable. I'm also not sure if my eccentricity calculations make any geometric sense but the effects ends up looking good enough.