Fix - diagnose-expression throws when Offset is nested
#42497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| enterCustomColumnDetails({ formula, name }); | ||
|
|
||
| cy.on("uncaught:exception", error => { | ||
| expect(error.message.includes("Error normalizing")).not.to.be.true; |
There was a problem hiding this comment.
what kind of error do we expect? is there any other way to verify we don't have normalization error?
There was a problem hiding this comment.
what kind of error do we expect?
We expect no error.
cy.on will however catch all the other errors from console, e.g. warnings about missing props coming from React, etc.
is there any other way to verify we don't have normalization error?
We could wrap Lib.diagnoseExpression call in diagnostics.ts in a try/catch block and then the error would be shown to the user. I'm not sure why we haven't done that originally.
ranquild
approved these changes
May 10, 2024
|
@kamilmielnik Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
uladzimirdev
pushed a commit
that referenced
this pull request
May 11, 2024
* Fix offset not working in case * Make offset function return any * Add a repro for #42377 * Fix order of adjustments * Revert unrelated changes * Remove commented code * Revert unrelated changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42377
Description
Switches the order of appliance of
adjustOffsetandadjustCase.How to verify
New e2e test passes.